Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Use timeline features for voice messages #2106

Closed
17 of 19 tasks
Tracked by #2057
jonnyandrew opened this issue Oct 5, 2023 · 6 comments
Closed
17 of 19 tasks
Tracked by #2057

[Story] Use timeline features for voice messages #2106

jonnyandrew opened this issue Oct 5, 2023 · 6 comments
Assignees
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@jonnyandrew
Copy link

jonnyandrew commented Oct 5, 2023

Description

Existing timeline features work as expected for voice messages. Much of this functionality may come for free.

Acceptance criteria

  • Retry a failed attempt to send
  • Reply to a voice message
  • Delete a voice message
  • React with emoji to a voice message
  • Admin powers (e.g. to delete) are honoured
  • The "copy" action should be removed since isn't helpful

Size estimate

None

Dependencies

Preconditions

No response

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Out of scope

  • Edit a voice message
  • Share voice messages to other apps
  • Decryption progress indicator
  • Typing notifications
  • Reply with a voice message
  • Auto-play consecutive voice messages

Open questions

No response

Subtasks

Android

  1. julioromano
  2. julioromano
  3. julioromano

iOS

  1. alfogrillo
  2. alfogrillo
  3. alfogrillo

Other

No tasks being tracked yet.
@alfogrillo
Copy link

@jonnyandrew can you clarify this?

Verified with build in screen reader

Does this means we expects all the actions in the timeline menu being read by the screen reader?
Currently on EXI actions in the timeline menu aren't read in general (for any event).

@jonnyandrew
Copy link
Author

jonnyandrew commented Oct 13, 2023

I don't think we need to reverify any existing features with a screen reader here but perhaps we can check that the new timeline item doesn't introduce any problems, for example we could check:

  • that we can traverse voice messages in the timeline with a screen reader
  • that it's possible to add a reaction directly to a voice message from the timeline with a screen reader
  • that the actions menu can be opened from a voice message with a screen reader

@alfogrillo
Copy link

alfogrillo commented Oct 16, 2023

I don't think we need to reverify any existing features with a screen reader here but perhaps we can check that the new timeline item doesn't introduce any problems, for example we could check:

  • that we can traverse voice messages in the timeline with a screen reader
  • that it's possible to add a reaction directly to a voice message from the timeline with a screen reader
  • that the actions menu can be opened from a voice message with a screen reader

Apparently we don't have the voice over (aka screen reader) at all in the timeline menu. Do you have it on EXA?

@jonnyandrew
Copy link
Author

Yeah on EXA the timeline menu does support screen readers. If it's not supported on iOS then we can't verify anything here but I think it'd be worth opening an issue about that.

@alfogrillo
Copy link

Yeah on EXA the timeline menu does support screen readers. If it's not supported on iOS then we can't verify anything here but I think it'd be worth opening an issue about that.

It seems we need very little work to have it on EXI.
No need for an additional issue. Open directly a PR.

@jonnyandrew
Copy link
Author

I've just tested this with a screen reader on Android. Long press (through double tap and hold) is not working on voice message items as it is with other timeline items.

@julioromano julioromano self-assigned this Oct 27, 2023
julioromano pushed a commit to element-hq/element-x-android that referenced this issue Oct 27, 2023
Shows voice messages in the room summary.
Shows voice messages in the reply context menu and composer.
Show replies to voice messages in the timeline. 

(before this PR voice messages were shown the same as audio messages)

Story: element-hq/element-meta#2106
julioromano pushed a commit to element-hq/element-x-android that referenced this issue Oct 27, 2023
@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Nov 9, 2023
@julioromano julioromano removed their assignment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

6 participants