Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show custom emoji's alt text in room list message preview #2435

Open
HarHarLinks opened this issue Jun 5, 2024 · 1 comment
Open

Show custom emoji's alt text in room list message preview #2435

HarHarLinks opened this issue Jun 5, 2024 · 1 comment
Labels
A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@HarHarLinks
Copy link

HarHarLinks commented Jun 5, 2024

Steps to reproduce

  1. enable room list message previews
  2. send/receive an MSC2545 "custom emoji" inline image that has a title and alt text "formatted_body": "<img data-mx-emoticon height=\"32\" src=\"mxc://tastytea.de/yPRKZOPRJnAxsUmQhmUTvaKO\" alt=\"neocat_sob\" title=\"neocat_sob\">",

Outcome

What did you expect?

as per MSC2545, the alt/title text of the <img> is the [custom emoji's] body. hence its alt/title text should be used in the message preview

What happened instead?

  • a message consisting solely of a custom emoji is completely ignored in the message preview. the previous one is shown instead
  • a message containing a custom emoji will be shown partially:
    image
    image

Operating system

I use arch btw

Browser information

yes

URL for webapp

develop.element.io

Application version

i meant to click element desktop, too late now... Element Nightly version: 2024060301 Crypto version: Rust SDK 0.7.0 (068a0af), Vodozemac 0.6.0

Homeserver

synapse 1.106.0

Will you send logs?

No

@dosubot dosubot bot added A-Emoji S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 5, 2024
@t3chguy t3chguy transferred this issue from element-hq/element-web Jun 5, 2024
@dbkr dbkr added X-Needs-Product More input needed from the Product team T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely and removed T-Defect labels Jun 27, 2024
@dbkr
Copy link
Member

dbkr commented Jun 27, 2024

Seems sensible to me, but this would be product's decision, although either way unlikely to be one for our roadmap I suspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

2 participants