Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected UTDs after resetting your identity #2610

Open
Tracked by #245
pmaier1 opened this issue Nov 4, 2024 · 3 comments
Open
Tracked by #245

Expected UTDs after resetting your identity #2610

pmaier1 opened this issue Nov 4, 2024 · 3 comments

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Nov 4, 2024

The following was tested on EXI 1.9.3. I expect to see similar behavior on Android and Web, though.

Steps to reproduce

  1. Sign-in to a new device
  2. During the FTUE process, decide to reset your identity
  3. Complete the process and sync

Expected outcome
After the identity reset, existing message keys in the key storage are lost. For that reason, it is expected that your (encrypted) message history will be UTD. These UTD messages should not be
a) displayed to the user
b) counted in the UTD reporting

There is an adjacent scenario, where, after the identity reset, the user would **re-**verify another device that was still logged in and holds some message keys. This device would then upload the message keys to the new key storage which would allow the new device to actually decrypt (parts of?) the message history.

Actual outcome
All encrypted rooms show your entire message history as UTD (unless the message keys were uploaded by another device as described above).

@mxandreas

@andybalaam
Copy link

@mxandreas : this is a valid concern, but we are not likely to work on it immediately.

@davidegirardi
Copy link

These UTD messages should not be
a) displayed to the user
...

I think the messages should not just disappear. We should show something explaining that encrypted history before this moment is not available because you reset your crypto identity.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Nov 13, 2024

As you've moved this to unprioritised, I just want to emphasize that I expect a huge fraction of users moving to EX will reset their identity along that way. They will all see UTDs everywhere and will report them to Posthog.

If you set up WhatsApp or others from scratch without backup, all your rooms will be empty as well. A general banner telling you that history is unavailable might be a good idea, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants