Show the correct shield status in tooltip for more conditions #28476
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
changed the title
|
I think that this will need some trickery to merge this with the JS side. Obviously, this can't be merged until the JS PR is merged, since it uses values defined in that PR. But I think that when the JS side gets merged, then TypeScript will complain because the |
uhoreg
requested review from
t3chguy,
MidhunSureshR,
a team and
BillCarsonFr
and removed request for
a team
4 tasks
t3chguy
approved these changes
Nov 18, 2024
BillCarsonFr
approved these changes
Nov 19, 2024
| break; | ||
|
|
||
| case EventShieldReason.VERIFICATION_VIOLATION: | ||
| shieldReasonMessage = _t("encryption|event_shield_reason_verification_violation"); |
There was a problem hiding this comment.
I think it shoud match the existing copy for verification violation in invisible crypto? Sender's verified identity has changed as per decryption_failure > sender_identity_previously_verified ?
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-js-sdk#4529
Fixes #28170
Checklist
public/exportedsymbols have accurate TSDoc documentation.