Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker nginx config to not force ipv6 #28771

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

yxie2023
Copy link

Per PR#28729: CLA is signed and am now contributing from "contrib" branch.

yxie2023 and others added 4 commits December 12, 2024 11:44
ipv6 support is automatically added via nginx docker's 10-listen-on-ipv6-by-default.sh.

This patch allows element-web to run on system with or without ipv6 enabled.
@yxie2023 yxie2023 requested a review from a team as a code owner December 19, 2024 03:40
@yxie2023 yxie2023 requested review from dbkr and t3chguy December 19, 2024 03:40
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yxie2023
❌ x


x seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Dec 19, 2024
@t3chguy
Copy link
Member

t3chguy commented Dec 19, 2024

It looks like one of your commits is owned by x and thus your CLA doesn't apply to it 8d3c191 (#28771)

You would need to rewrite that commit/rebase the PR into a single commit

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants