Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming device verification request not displayed in EX #3120

Closed
Tracked by #2464
richvdh opened this issue Jul 1, 2024 · 6 comments
Closed
Tracked by #2464

Incoming device verification request not displayed in EX #3120

richvdh opened this issue Jul 1, 2024 · 6 comments
Assignees
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@richvdh
Copy link
Member

richvdh commented Jul 1, 2024

Steps to reproduce

  1. Create new session in Element Web
  2. Send verification request from EW ("Verify this device", "Verify with another device")
  3. Wait

Outcome

What did you expect?

"Incoming verification request", or words to that effect

What happened instead?

Nada

Your phone model

No response

Operating system version

No response

Application version and app store

0.4.14

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

No

@richvdh richvdh added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 1, 2024
@richvdh
Copy link
Member Author

richvdh commented Jul 1, 2024

The rageshake shows

2024-07-01T15:15:43.185272Z  INFO matrix_sdk_crypto::verification::machine: Received a new verification request from_device="KTEXQYNPGN" | crates/matrix-sdk-crypto/src/verification/machine.rs:342 | spans: next_sync_with_lock > sync_once{pos="3"} > handle_response > preprocess_to_device_events > receive_sync_changes > receive_to_device_event{sender="@steve:loynes.modular.im" event_type="m.key.verification.request" } > receive_any_event

but nothing else relevant after that?

@richvdh
Copy link
Member Author

richvdh commented Jul 1, 2024

Is this maybe the same as matrix-org/matrix-rust-sdk#3595?

@richvdh
Copy link
Member Author

richvdh commented Jul 1, 2024

According to element-hq/element-x-ios#1227, this just isn't implemented yet!

@ganfra
Copy link
Member

ganfra commented Jul 1, 2024

Exactly! Closing the issue :)

@manuroe
Copy link
Member

manuroe commented Jul 2, 2024

I created a meta issue for this feature: element-hq/element-meta#2464. I use this issue as the task to implement it on Android.

@manuroe manuroe added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jul 2, 2024
@bmarty bmarty self-assigned this Oct 21, 2024
@manuroe
Copy link
Member

manuroe commented Oct 31, 2024

@bmarty can we close this issue thanks to #3733?

@bmarty bmarty closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

No branches or pull requests

4 participants