-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waveform to voice message preview UI #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I found a minor issue though: if you are playing the recorded message and either delete it or send it, it will continue playing.
Thanks for testing! The issue with the send button is known but not the delete button - I'll fix that in a follow up |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
import kotlinx.collections.immutable.toPersistentList | ||
import kotlin.random.Random | ||
|
||
object FakeWaveformFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me the codebase tends to prefer top level function for these things: fun aFakeWaveform()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll fix in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
Add waveform to voice message preview UI.
Seeking and playback progress to follow.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist