Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waveform to voice message preview UI #1661

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 27, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add waveform to voice message preview UI.

Seeking and playback progress to follow.

Motivation and context

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 27, 2023 10:03
@jonnyandrew jonnyandrew requested review from jmartinesp and julioromano and removed request for a team October 27, 2023 10:03
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I found a minor issue though: if you are playing the recorded message and either delete it or send it, it will continue playing.

@jonnyandrew
Copy link
Contributor Author

Thanks for testing! The issue with the send button is known but not the delete button - I'll fix that in a follow up

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/j7sJnF

import kotlinx.collections.immutable.toPersistentList
import kotlin.random.Random

object FakeWaveformFactory {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me the codebase tends to prefer top level function for these things: fun aFakeWaveform()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll fix in a follow up

@jonnyandrew jonnyandrew enabled auto-merge (squash) October 27, 2023 11:15
Copy link

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit 9510d43 into develop Oct 27, 2023
16 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-message-preview-waveform branch October 27, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants