Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics for voice messages #1706

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Add analytics for voice messages #1706

merged 4 commits into from
Nov 2, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 31, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Analytics

Content

Add analytics for voice messages.

Also, rename a test fake used in the related test.

Motivation and context

Screenshots / GIFs

Tests

Unit test

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Copy link
Contributor

github-actions bot commented Oct 31, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bsAGQv

@ElementBot
Copy link
Collaborator

ElementBot commented Nov 1, 2023

Warnings
⚠️

gradle/libs.versions.toml#L64 - A newer version of com.google.android.material:material than 1.9.0 is available: 1.10.0

⚠️

gradle/libs.versions.toml#L102 - A newer version of androidx.compose.material3:material3 than 1.2.0-alpha09 is available: 1.2.0-alpha10

Generated by 🚫 dangerJS against d1898de

@jonnyandrew jonnyandrew marked this pull request as ready for review November 1, 2023 10:01
@jonnyandrew jonnyandrew requested a review from a team as a code owner November 1, 2023 10:01
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team November 1, 2023 10:01
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a73cd8a) 63.45% compared to head (d1898de) 63.45%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1706   +/-   ##
========================================
  Coverage    63.45%   63.45%           
========================================
  Files         1282     1282           
  Lines        33267    33274    +7     
  Branches      6885     6885           
========================================
+ Hits         21108    21115    +7     
  Misses        8976     8976           
  Partials      3183     3183           
Files Coverage Δ
...messages/composer/VoiceMessageComposerPresenter.kt 94.11% <100.00%> (+0.67%) ⬆️
...atures/messages/test/FakeMessageComposerContext.kt 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit dab5e0d into develop Nov 2, 2023
15 of 17 checks passed
@jonnyandrew jonnyandrew deleted the jonny/vm-analytics branch November 2, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants