Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication - no behavior change. #3823

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 7, 2024

Quick PR to make the code more readable.
This should have no impact on screenshots, no impact at all actually.

@bmarty bmarty requested a review from a team as a code owner November 7, 2024 09:00
@bmarty bmarty requested review from ganfra and removed request for a team November 7, 2024 09:00
Copy link
Contributor

github-actions bot commented Nov 7, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MEGCeV

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (9ea0a11) to head (d462386).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3823      +/-   ##
===========================================
- Coverage    82.98%   82.98%   -0.01%     
===========================================
  Files         1782     1782              
  Lines        44865    44860       -5     
  Branches      5265     5265              
===========================================
- Hits         37233    37228       -5     
  Misses        5793     5793              
  Partials      1839     1839              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 213dc77 into develop Nov 7, 2024
27 checks passed
@bmarty bmarty deleted the feature/bma/lastDevice branch November 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant