Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : display security banner for room list empty state #3892

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Nov 19, 2024

Content

Display security banner on room list empty state too.

Motivation and context

https://github.com/element-hq/customer-success/issues/383

Screenshots / GIFs

Check recorded screenshots.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Bugfix For bug fix labels Nov 19, 2024
@ganfra ganfra marked this pull request as ready for review November 19, 2024 10:09
@ganfra ganfra requested a review from a team as a code owner November 19, 2024 10:09
@ganfra ganfra requested review from bmarty and removed request for a team November 19, 2024 10:09
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2sABV1

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (2405542) to head (71e65cd).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...es/roomlist/impl/components/RoomListContentView.kt 82.14% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3892      +/-   ##
===========================================
- Coverage    82.90%   82.89%   -0.01%     
===========================================
  Files         1785     1785              
  Lines        45111    45132      +21     
  Branches      5328     5329       +1     
===========================================
+ Hits         37398    37414      +16     
- Misses        5844     5847       +3     
- Partials      1869     1871       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
@ganfra ganfra merged commit 03d9f3d into develop Nov 19, 2024
29 checks passed
@ganfra ganfra deleted the feature/fga/room_list_security_banner_empty_state branch November 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants