Remove snapshotting delay option.

element-hq · Dec 20, 2024 · a7c3682 · a7c3682
1 parent d4a977d
commit a7c3682
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/ElementX/Sources/Other/Extensions/Snapshotting.swift b/ElementX/Sources/Other/Extensions/Snapshotting.swift
@@ -17,14 +17,6 @@
 import Combine
 import SwiftUI
 
-struct SnapshotDelayPreferenceKey: PreferenceKey {
-    static var defaultValue: TimeInterval = 0.0
-
-    static func reduce(value: inout TimeInterval, nextValue: () -> TimeInterval) {
-        value = nextValue()
-    }
-}
-
 struct SnapshotPrecisionPreferenceKey: PreferenceKey {
     static var defaultValue: Float = 1.0
 
@@ -74,13 +66,4 @@ extension SwiftUI.View {
             .preference(key: SnapshotPerceptualPrecisionPreferenceKey.self, value: perceptualPrecision)
             .preference(key: SnapshotFulfillmentPublisherPreferenceKey.self, value: FulfillmentPublisherEquatableWrapper(publisher: fulfillmentPublisher?.eraseToAnyPublisher()))
     }
-
-    @available(*, deprecated, message: "Use the fulfillment variant instead")
-    func snapshotPreferences(delay: TimeInterval = .zero,
-                             precision: Float = 1.0,
-                             perceptualPrecision: Float = 0.98) -> some SwiftUI.View {
-        preference(key: SnapshotDelayPreferenceKey.self, value: delay)
-            .preference(key: SnapshotPrecisionPreferenceKey.self, value: precision)
-            .preference(key: SnapshotPerceptualPrecisionPreferenceKey.self, value: perceptualPrecision)
-    }
 }
diff --git a/PreviewTests/Sources/PreviewTests.swift b/PreviewTests/Sources/PreviewTests.swift
@@ -55,7 +55,6 @@ class PreviewTests: XCTestCase {
         let preferences = SnapshotPreferences()
 
         let preferenceReadingView = preview.content
-            .onPreferenceChange(SnapshotDelayPreferenceKey.self) { preferences.delay = $0 }
             .onPreferenceChange(SnapshotPrecisionPreferenceKey.self) { preferences.precision = $0 }
             .onPreferenceChange(SnapshotPerceptualPrecisionPreferenceKey.self) { preferences.perceptualPrecision = $0 }
             .onPreferenceChange(SnapshotFulfillmentPublisherPreferenceKey.self) { preferences.fulfillmentPublisher = $0?.publisher }
@@ -64,11 +63,6 @@ class PreviewTests: XCTestCase {
         let imageRenderer = ImageRenderer(content: preferenceReadingView)
         _ = imageRenderer.uiImage
 
-        // Delay the test now - a delay after creating the `snapshotView` results in the underlying view not getting updated for snapshotting.
-        if preferences.delay != .zero {
-            wait(for: preferences.delay)
-        }
-
         if let fulfillmentPublisher = preferences.fulfillmentPublisher {
             let deferred = deferFulfillment(fulfillmentPublisher) { $0 == true }
             try await deferred.fulfill()
@@ -141,7 +135,6 @@ class PreviewTests: XCTestCase {
 }
 
 private class SnapshotPreferences: @unchecked Sendable {
-    var delay: TimeInterval = 0
     var precision: Float = 1
     var perceptualPrecision: Float = 1
     var fulfillmentPublisher: AnyPublisher<Bool, Never>?