Add a fullscreen button to TimelineMediaPreviewScreen and hook up swiping through the timeline. #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
added
the
pr-wip
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3638 +/- ##
===========================================
- Coverage 78.64% 78.61% -0.04%
===========================================
Files 788 788
Lines 66590 66643 +53
===========================================
+ Hits 52371 52389 +18
- Misses 14219 14254 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Not ideal but the gestures conflict with the preview controller.
pixlwave
force-pushed
the
doug/full-screen-button
branch
from
4ac308a to
6ab2441
Compare
Velin92
reviewed
Dec 18, 2024
ElementX/Sources/Screens/FilePreviewScreen/View/TimelineMediaPreviewScreen.swift
Show resolved
Hide resolved
Velin92
reviewed
Dec 18, 2024
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewCoordinator.swift
Show resolved
Hide resolved
Velin92
approved these changes
Dec 18, 2024
pixlwave
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal, but a good enough workaround for now as adding a tap gesture would conflict with the preview controller.
Additionally adds a second attempt to stop the thumbnail appearing upside-down while dismissing the view (should work on iOS 18.1 and 18.2 this time, although there is occasionally a small flicker).
Additionally additionally, all of the items in the media events timeline are now loaded into the preview controller so that you can swipe between them. (Pagination not included).
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-18.at.13.24.09.mp4