Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow disabling read receipts #1150

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Half-Shot
Copy link
Member

To allow upstream apps the ability to stop sending them.

Copy link

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MidhunSureshR
Copy link
Member

I'm a bit concerned about having code in Hydrogen that solves a very specific use case of a downstream project. In this case, ideally we'd have a ReadOnlyRoomViewModel that disables sending messages, read receipts and calls. I'm going to merge this now but I've also created #1151

@MidhunSureshR MidhunSureshR merged commit 145189f into master Nov 8, 2023
2 checks passed
@Half-Shot
Copy link
Member Author

Yeah, I agree. I think in this case the problem was that the read receipt code was somewhat burred in the Room component. Perhaps we can fix that next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants