Refactor transaction handler. #20

Half-Shot · 2023-06-29T13:02:18Z

This:

Moves the actual transaction handling logic to it's own function.
Uses a Map to store the txnId => Promise .
Always clears up transactions after they've run.

tadzik · 2023-06-29T13:39:02Z

src/appservice/Appservice.ts


        try {
-            await this.pendingTransactions[txnId];
+            await txnHandler;
            await Promise.resolve(this.storage.setTransactionCompleted(txnId));


Not strictly related to this PR, but this await Promise.resolve is a bit superfluous, and a bit confusing.

tadzik

No complaints, looks good to me.

Refactor transaction handler.

5617a1f

Half-Shot requested a review from a team as a code owner June 29, 2023 13:02

tadzik reviewed Jun 29, 2023

View reviewed changes

tadzik approved these changes Jun 29, 2023

View reviewed changes

Fix races

a0c209e

Half-Shot merged commit cfae65f into element-hq:main Jul 3, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor transaction handler. #20

Refactor transaction handler. #20

Half-Shot commented Jun 29, 2023 •

edited

Loading

tadzik Jun 29, 2023

tadzik left a comment

Refactor transaction handler. #20

Refactor transaction handler. #20

Conversation

Half-Shot commented Jun 29, 2023 • edited Loading

tadzik Jun 29, 2023

Choose a reason for hiding this comment

tadzik left a comment

Choose a reason for hiding this comment

Half-Shot commented Jun 29, 2023 •

edited

Loading