Add support for key backups #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFerr
force-pushed
the
af/key-backups
branch
from
74f8864
to
e885b88
Compare
|
This currently merges in a few dependent branches that should be submitted before this PR is. |
on account of it being removed from the crypto-sdk
OlmMachine.receiveSyncChanges returns an array of [device messages, room key changes], so emit "to_device.decrypted" with that instead of the entire array. Fixes regression introduced by turt2live#287.
Also condense the validity checks on the returned value
AndrewFerr
force-pushed
the
af/key-backups
branch
from
834e539
to
64463f4
Compare
AndrewFerr
changed the title
tadzik
suggested changes
Aug 4, 2023
Also add/tweak some utility types to help with this
|
The added test covers creating & retrieving key backup versions (i.e. which pubkey to use, and what backup version it is). Yet to be tested is the act of backing up keys. |
|
The remaining tests have been added, and it was very much worth it, as doing so revealed a bug & a few code improvements to be made. Barring review feedback, this PR should be good to go. |
tadzik
reviewed
Aug 10, 2023
tadzik
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[ ] Sign-off given on the changes (see CONTRIBUTING.md)