Remove Generator in _prune_old_outbound_device_pokes (#17814)

Context: matrix-org/synapse#15439 (#15439) Also see discussion in #17813
element-hq · Oct 31, 2024 · 47fe6df · 47fe6df
1 parent 034d472
commit 47fe6df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/17814.bugfix b/changelog.d/17814.bugfix
@@ -0,0 +1 @@
+Avoid lost data on some database query retries.
diff --git a/synapse/storage/databases/main/devices.py b/synapse/storage/databases/main/devices.py
@@ -1422,7 +1422,7 @@ def _prune_txn(txn: LoggingTransaction) -> None:
                 DELETE FROM device_lists_outbound_last_success
                 WHERE destination = ? AND user_id = ?
             """
-            txn.execute_batch(sql, ((row[0], row[1]) for row in rows))
+            txn.execute_batch(sql, [(row[0], row[1]) for row in rows])
 
             logger.info("Pruned %d device list outbound pokes", count)