Make admin api redactions use the requester to send the redaction (#1…

…8029)
element-hq · Dec 23, 2024 · 7c2284b · 7c2284b
1 parent d69c00b
commit 7c2284b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/18029.bugfix b/changelog.d/18029.bugfix
@@ -0,0 +1 @@
+Fix a bug preventing the admin redaction endpoint from working on messages from remote users.
diff --git a/synapse/handlers/admin.py b/synapse/handlers/admin.py
@@ -473,7 +473,7 @@ async def _redact_all_events(
                     "type": EventTypes.Redaction,
                     "content": {"reason": reason} if reason else {},
                     "room_id": room,
-                    "sender": user_id,
+                    "sender": requester.user.to_string(),
                 }
                 if room_version.updated_redaction_rules:
                     event_dict["content"]["redacts"] = event.event_id
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug preventing the admin redaction endpoint from working on messages from remote users.