Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/_matrix/client/v3/register fails over unix socket #16742

Open
matrixbot opened this issue Dec 21, 2023 · 1 comment
Open

/_matrix/client/v3/register fails over unix socket #16742

matrixbot opened this issue Dec 21, 2023 · 1 comment

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #16742.


Description

cp. #16404.

I had a quick glance at the code; Since the IP may be necessary later during execution I couldn't come up with a PR that just replaces the occurences with .get_client_ip_if_available() in register.py

Steps to reproduce

cp. #16404

Homeserver

selfhosted

Synapse Version

1.95.1

Installation Method

Other (please mention below)

Database

postgresql

Workers

Single process

Platform

archlinux arm

Configuration

No response

Relevant log output

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/synapse/http/server.py", line
 326, in _async_render_wrapper
    callback_return = await self._async_render(request)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/synapse/http/server.py", line
 538, in _async_render
    callback_return = await raw_callback_return
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/synapse/rest/client/_base.py"
, line 102, in wrapped
    return await orig(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/synapse/rest/client/register.
py", line 436, in on_POST
    client_addr = request.getClientAddress().host
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'UNIXAddress' object has no attribute 'host'

Anything else that would be useful to know?

No response

@matrixbot matrixbot changed the title Dummy issue /_matrix/client/v3/register fails over unix socket Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
@witchent
Copy link

I have the same problem, which makes using bridges on unix sockets pretty much impossible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants