Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchrotrons always wake up sync streams for presence updates #8955

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

Synchrotrons always wake up sync streams for presence updates #8955

matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #8955.


When calculating presence changes we decide whether we should actively wake up sync streams, or if they should just be bundled up the next time we send a response for another reason. We do not appear to propagate whether to wake up sync streams across replication, and we appear to always notify for presence updates:

https://github.com/matrix-org/synapse/blob/6d02eb22dfde9551c515acaf73503e2500e00eaf/synapse/app/generic_worker.py#L381-L390

It's unclear how much this will help.

(Note that we batch up presence updates that we don't notify for and persist/replicate them once a minute).

@matrixbot matrixbot changed the title Dummy issue Synchrotrons always wake up sync streams for presence updates Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant