Add some debug to keep track of client state desynchronisation #16952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/log_state_desync
branch
2 times, most recently
from
463d6e6
to
e41a755
Compare
|
Putting this back in draft for now. It's really not obvious to me that this is going to tell us anything useful. |
... to represent the last point in the room we actually want to return state from.
Pass the `end_token` down into `compute_state_delta` instead of `now_token`, and use it to calculate the state at the end of the timeline.
Fix an issue which could cause state to be omitted from the sync response if the last event was filtered out. Fixes: #16928
Unfortunately, the optimisation we applied here for non-gappy syncs is not actually valid.
richvdh
force-pushed
the
rav/log_state_desync
branch
from
128a404
to
e6d7c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to add some logging to see how often the client is ending up with room state that differs from the "current state". As the comments say, this should catch things caused by both state changes outside the timeline (matrix-org/matrix-spec#1209), and the fact that Synapse doesn't actually return the current state (#16940).
Fixes https://github.com/element-hq/crypto-internal/issues/179
Based on #16942