-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliding Sync: Return room tags in account data extension #17707
Merged
MadLittleMods
merged 12 commits into
develop
from
madlittlemods/17694-room-tags-in-account-data-extension
Sep 16, 2024
Merged
Sliding Sync: Return room tags in account data extension #17707
MadLittleMods
merged 12 commits into
develop
from
madlittlemods/17694-room-tags-in-account-data-extension
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonh
requested changes
Sep 13, 2024
devonh
approved these changes
Sep 16, 2024
MadLittleMods
deleted the
madlittlemods/17694-room-tags-in-account-data-extension
branch
September 16, 2024 18:47
Thanks for the review @devonh 🐏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return room tags in account data extension
The account data extension was also updated to avoid copies when we pull the data out of the cache.
Fix #17694
Dev notes
Sync v2 incremental sync response with some rooms tags in the account data (favouriting a room)
ChainMap
DeepChainMap
example in the Python docs: https://docs.python.org/3/library/collections.htmlaka
NestedChainMap
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)