Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract server from roomId to get hierarchy over federation #17750

Closed
wants to merge 4 commits into from

Conversation

kfiven
Copy link
Contributor

@kfiven kfiven commented Sep 24, 2024

Fixes remaining parts of #17143

The change actually need via parameter in the /hierarchy endpoint in spec, but IMO temporarily its a good fix to at least look for the server extracting from the room id rather than nothing.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Trying to fix element-hq#17143 again

The change actually need via parameter in the /hierarchy endpoint in spec, but IMO temporarily its a good fix to atleast look for the server extracting from the room id rather than nothing.
@kfiven kfiven requested a review from a team as a code owner September 24, 2024 11:37
@kfiven kfiven changed the title Add via param for requested room id federeation hierarchy search Extract server from roomId to get hierarchy over federation Sep 28, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024

CLA assistant check
All committers have signed the CLA.

@anoadragon453
Copy link
Member

Thanks for making this PR. I'm afraid that domains in room IDs are really intended just for namespacing, and are not meant to be extracted and used for other purposes.

As you say, the real fix is to include the domain in the via parameters. While this fix would help with some cases in the wild, domains in room IDs aren't meant to be used in that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants