Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to Twisted 24.10.0rc1 #17886

Closed
wants to merge 8 commits into from
Closed

Adapt to Twisted 24.10.0rc1 #17886

wants to merge 8 commits into from

Conversation

Yushu2606
Copy link

@Yushu2606 Yushu2606 commented Oct 30, 2024 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

dependabot bot and others added 2 commits October 28, 2024 10:26
@dependabot
Bump twisted from 24.7.0 to 24.10.0
0f73c75 
Bumps [twisted](https://github.com/twisted/twisted) from 24.7.0 to 24.10.0.
- [Release notes](https://github.com/twisted/twisted/releases)
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst)
- [Commits](twisted/twisted@twisted-24.7.0...twisted-24.10.0)

---
updated-dependencies:
- dependency-name: twisted
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Yushu2606
feat: adapt to Twisted 24.10.0rc1
4a98914
@Yushu2606 Yushu2606 requested a review from a team as a code owner October 30, 2024 02:41
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Yushu2606
Copy link
Author

#17878

@S7evinK
Copy link
Contributor

S7evinK commented Oct 30, 2024

Can you incorporate the changes from #17878 in this PR? CI is complaining that _nameEncoder can not be found (well, Twisted isn't updated yet, so that makes sense)

@Yushu2606
Copy link
Author

Can you incorporate the changes from #17878 in this PR? CI is complaining that _nameEncoder can not be found (well, Twisted isn't updated yet, so that makes sense)

ok, sure

@devonh
Copy link
Member

devonh commented Nov 7, 2024

These changes have been superceded by this PR #17894.
It removes the usage of internal header encoding API completely.

@devonh devonh closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yushu2606 @CLAassistant @S7evinK @devonh