Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of internal header encoding API #17894

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 1, 2024

Remove usage of internal header encoding API.

from twisted.web.http_headers import Headers

Headers()._canonicalNameCaps
Headers()._encodeName

Spawning from wanting to upgrade Twisted which no longer has these API's.

Introduced in matrix-org/synapse#15913 <- matrix-org/synapse#15773

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods changed the title Remove usage on internal header encoding API Remove usage of internal header encoding API Nov 1, 2024
@MadLittleMods MadLittleMods marked this pull request as ready for review November 1, 2024 17:25
@MadLittleMods MadLittleMods requested a review from a team as a code owner November 1, 2024 17:25
@MadLittleMods MadLittleMods merged commit 2c9ed5e into develop Nov 4, 2024
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/remove-usage-of-internal-header-encoding-api branch November 4, 2024 18:20
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @erikjohnston 🐦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants