Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for python 3.8 #17908

Merged
merged 15 commits into from
Nov 6, 2024
Merged

Remove support for python 3.8 #17908

merged 15 commits into from
Nov 6, 2024

Conversation

devonh
Copy link
Member

@devonh devonh commented Nov 6, 2024

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@devonh devonh requested a review from a team as a code owner November 6, 2024 17:00
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:01 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:02 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:13 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:31 Active
anoadragon453
anoadragon453 requested changes Nov 6, 2024
View reviewed changes
.ci/scripts/prepare_old_deps.sh Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
docs/setup/installation.md Outdated Show resolved Hide resolved
docs/upgrade.md Outdated Show resolved Hide resolved
docs/upgrade.md Outdated Show resolved Hide resolved
scripts-dev/build_debian_packages.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
scripts-dev/build_debian_packages.py Outdated Show resolved Hide resolved
devonh and others added 5 commits November 6, 2024 17:41
@devonh @anoadragon453
Update docs/setup/installation.md
256a9bb 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@devonh @anoadragon453
Update docs/upgrade.md
7d1266c 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@devonh @anoadragon453
Update scripts-dev/build_debian_packages.py
597d524 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@devonh @anoadragon453
Update scripts-dev/build_debian_packages.py
dcae840 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@devonh @anoadragon453
Update tox.ini
115556d 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:42 Active
@anoadragon453
Copy link
Member

this container build job can also be removed, but that can be done in a separate PR/release.

@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:46 Active
anoadragon453
anoadragon453 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once CI passes.

@anoadragon453 anoadragon453 mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:11 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:30 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:33 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 19:04 Active
@devonh devonh merged commit eda735e into develop Nov 6, 2024
42 checks passed
@devonh devonh deleted the devon/deprecate-py38 branch November 6, 2024 19:36
bmarty added a commit to element-hq/element-android that referenced this pull request Nov 12, 2024
@bmarty
Move to Python 3.9
2f3aff5 
Synapse require 3.9 since element-hq/synapse#17908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devonh @anoadragon453