Properly purge state groups tables when purging a room #18024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
fix-purge-room-state-groups
branch
from
edf674a to
81cadd8
Compare
MatMaul
force-pushed
the
fix-purge-room-state-groups
branch
from
81cadd8 to
7945610
Compare
erikjohnston
requested changes
Dec 18, 2024
erikjohnston
approved these changes
Dec 20, 2024
Comment on lines
+880
to
882
| column="room_id", | ||
| values=[room_id], | ||
| keyvalues={}, |
There was a problem hiding this comment.
Suggested change
| column="room_id", | |
| values=[room_id], | |
| keyvalues={}, | |
| keyvalues={"room_id": room_id}, |
| logger.info("[purge] removing %s from state_groups", room_id) | ||
|
|
||
| self.db_pool.simple_delete_many_txn( |
There was a problem hiding this comment.
Suggested change
| self.db_pool.simple_delete_many_txn( | |
| self.db_pool.simple_delete_txn( |
erikjohnston
requested changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently purging a complex room can lead to a lot of orphaned rows left behind in the state groups tables.
It seems it is because we are loosing track of state groups sometimes.
This change uses the
room_idindexed column ofstate_groupstable to decide what to delete instead of doing an indirection throughevent_to_state_groups.Related to #3364.
Pull Request Checklist
(run the linters)