-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put branch name on separate line #1423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Is this something that needs to be run by UX?
@zeebok. Thanks for the review. Not sure if the design change is significant but I'll request a review from UX anyway. I wanted to wrap the text but it doesn't seem possible in SourceList so I had to hard code two lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the newline for the branch name makes sense here, but I'm -1 on making the project name even larger
I find it useful to have the project names more prominent and easily readable but maybe I need new glasses ... |
Co-authored-by: Danielle Foré <danielle@elementary.io>
Fixes #574
Makes current branch visible without excessive sidebar width when both project and branch have long names