Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define terminal menu items using GLib.MenuModel #1438

Merged

Conversation

colinkiama
Copy link
Member

Replaces usage of Gtk.MenuItem with GLib.MenuModel in the Terminal widget as #1157

@colinkiama colinkiama requested a review from a team June 17, 2024 16:40
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! Just a couple of comments

src/Widgets/Terminal.vala Outdated Show resolved Hide resolved
src/Widgets/Terminal.vala Outdated Show resolved Hide resolved
src/Widgets/Terminal.vala Outdated Show resolved Hide resolved
@colinkiama colinkiama requested a review from danirabbit June 18, 2024 07:27
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@danirabbit danirabbit merged commit fa30c67 into master Jun 18, 2024
6 checks passed
@danirabbit danirabbit deleted the colinkiama/render-terminal-menu-items-with-menu-model branch June 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants