Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: bump libvala dependency #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kaixoo
Copy link

@kaixoo kaixoo commented Dec 21, 2024

OS 8 doesn't seem to have libvala-0.48-dev anymore

user@pc:~$ sudo apt install libvala-0.48-dev
Lecture des listes de paquets... Fait
Construction de l'arbre des dépendances... Fait
Lecture des informations d'état... Fait      
E: Impossible de trouver le paquet libvala-0.48-dev
E: Impossible de trouver de paquet correspondant à l'expression rationnelle « libvala-0.48-dev »

OS 8 doesn't seem to have `libvala-0.48-dev` anymore
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK as OS7 has v0.56. The libvala dependency automatically adjusts to the version of vala compiler installed so we should probably specify the same minimum version for valac

@kaixoo
Copy link
Author

kaixoo commented Dec 21, 2024

so we should probably specify the same minimum version for valac

I didn't want to touch the minimum version. Just adjusting the recommended version because 0.48 no longer exists in OS 8.

@jeremypw
Copy link
Collaborator

I don't know what the true minimum version of vala required to compile the code is now tbh. But we only support compiling on the current release of elementary (8) and the previous one (7) anyway so we generally bump the dependencies accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants