WIP: Actions: Make edit-clear more consistent #1146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- edit-clear: red backspace symbol - edit-clear-symbolic: red backspace symbol, error class added - edit-clear-all and edit-clear-all-symbolic: broom symbol
|
If by Github search you meant search other projects, it looks like there might be 3 places in other projects: |
|
I'll also add, while In places where they are used, there doesn't seem to be any actionable difference between the two -- they both clear all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danirabbit , you mentioned in the issue
I wasn't totally sure what enabling the fallbacks meant or where exactly to look. I checked for symlinks and the like and didn't find any that needed changing, but wasn't sure what more to do (edit: see followup reply). The rest I think should be on the right track. Moved
edit-clearBroom icons toedit-clear-all, makeedit-clearall use the red Backspace symbol. I did add theerrorclass to the symbolicedit-clearicons to make them red if that is okay.One thing I'm not sure on is the sizes. I did a new
edit-clearbased on themail-mark-importanticon (as mentioned in the issue) at 16px. Should this be done at other sizes? I'm not sure that these icons are used beyond the text-entry boxes (16px) or possibly toolbar icons (24px), so I'm not sure that 32x, 48px, etc are needed (and if not should the largeredit-clear-allicons be removed as well?).Current:
Proposed:
Also played with making the new regular
edit-cleara few pixels longer vs a little more square (edit-clear0), wasn't sure which to go with but I like the longer one a little more, it's a bit more legible:Git Log:
edit-clear: red backspace symboledit-clear-symbolic: red backspace symbol, error class addededit-clear-allandedit-clear-all-symbolic: broom symbolFixes #1126