MainWindow: Move Actions and Keyboard Handling Related to The View to TerminalWidget #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
requested changes
Nov 25, 2023
Marukesu
force-pushed
the
maru/terminal-actions
branch
from
a297afa to
2d0f480
Compare
jeremypw
requested changes
Nov 27, 2023
Marukesu
force-pushed
the
maru/terminal-actions
branch
from
2d0f480 to
87878d2
Compare
jeremypw
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Its a pity this change turned out to be less straightforward than anticipated and a somewhat non-obvious workround is required to avoid breaking some actions. However this all seems to work now. So I guess it can be merged.
Maybe possible to refactor simplify later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of reducing the size of the MainWindow class, these was relying on the current_terminal property to work, however, both key handling and actions goes from the focused widget to the topmost parent. so we can move them to TerminalWidget class without problems.