-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for unsafe drop #794
Conversation
The issue was marked critical, but the PR seems out of date - Any ETA for merging ? |
I marked it critical because the issue has theoretical security implications, but its not a new issue. I guess folks are focused on getting OS8 released atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clipboard or dragged text are no longer pasted if we once uncheck "Show paste protection warnings" in the UnsafePasteDialog.
@ryonakano Oops! Thanks for spotting that. Now fixed. It occurred to me that if unsafe paste alert is turned off in the dialog, there is no way of turning it back on through the UI. Am I right? If so that needs fixing but in another PR. |
I noticed that this PR was pasting the stripped text into the terminal whereas in master, the text was refetched from the clipboard. Now the stripped text is only used for the dialog message as before. |
following your comment i did a PR for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clipboard or dragged text are no longer pasted if we once uncheck "Show paste protection warnings" in the UnsafePasteDialog.
Confirmed this is fixed, thank you!
Leaving another two tiny comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and fixes the linked issue. Thank you!
Fixes #793
In order to use the same code to check for unsafe input, both paste and drop end up feeding the text to the terminal child. This actually saves some lines.