Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests to use save files not in the main repo #143

Merged
merged 3 commits into from
May 13, 2024

Conversation

chennin
Copy link
Contributor

@chennin chennin commented May 10, 2024

Change how test saves are stored to address main repo size concerns

  • Change the saves directory to a submodule repo I created (I will add collaborators, or, I don't need to be the one to own it)
  • Change the real_save test to use a temp directory that pytest will automatically clean up
  • And fail if zero output .dbs are created (it'd take more work to automate that number, complicated by the fact that if we ever put multiple saves from the same game in, they will go to the same db)
  • Check the submodule out in the github action
  • List tests more verbosely for when we want to manually confirm one ran
  • Tests pass and output artifacts are the same size (example, example)

@chennin
Copy link
Contributor Author

chennin commented May 11, 2024

@eliasdoehne here's a solution to adding more test saves without bloating the size of the main repo - what do you think?

@MichaelMakesGames
Copy link
Collaborator

Looks good to me. I'll wait a bit before merging to give Elias a chance to respond

@eliasdoehne
Copy link
Owner

Looks good to me 👍

@MichaelMakesGames MichaelMakesGames merged commit b07c607 into eliasdoehne:master May 13, 2024
3 checks passed
@chennin chennin deleted the split-tests branch May 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants