Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cython 3.0 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

orbisvicis
Copy link

Fixes errors and warnings when building against Cython 3.0, except the deprecation of "IF". Of special attention, I reverted the workaround for "INT32_MIN" and "INT64_MIN" in "src/aiolo/pack.pyx". I believe the original issue was due to a typo in the "libc.stdint" imports.

@orbisvicis
Copy link
Author

orbisvicis commented Jul 26, 2023

I also added exception handling to three functions in src/aiolo/lo.pxd, to match the new Cython defaults but also because I think exceptions may be raised in sections running with the GIL - might want to confirm that.

Fixes errors and warnings when building against Cython 3.0, except the
deprecation of "IF". Of special attention, I reverted the workaround for
"INT32_MIN" and "INT64_MIN" in "src/aiolo/pack.pyx". I believe the
original issue was due to a typo in the "libc.stdint" imports.
@orbisvicis
Copy link
Author

This is blocked by this Cython 3.x bug: cython/cython#5240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant