Support JSON #4566
Merged
Support JSON #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
reviewed
Jan 10, 2025
v0idpwn
reviewed
Jan 10, 2025
v0idpwn
approved these changes
Jan 10, 2025
v0idpwn
reviewed
Jan 10, 2025
Wigny
reviewed
Jan 10, 2025
|
Should this change also add Elixir 1.18 to CI? |
|
Good call, yes. |
|
CI fails for other reasons, I will look at it locally. |
I think I fixed it up, though I'm not sure if the added |
|
Oh no, @TylerWitt , we raced each other, sorry. Can you please revert the commit that adds v1.18 and rebase? Then we will be all good. :) |
Includes a bump on Decimal to get the tests to pass.
|
No worries! |
Co-authored-by: Wígny Almeida <Wigny@users.noreply.github.com>
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bump on Decimal to get the tests to pass.
Part of the needed changes to support JSON from Elixir 1.18. See #4565