From ffecfd7cc88851871fe24ee67cda56d5bb737535 Mon Sep 17 00:00:00 2001 From: Josh B <30708316+joshbax189@users.noreply.github.com> Date: Wed, 30 Oct 2024 19:18:35 +1300 Subject: [PATCH] Fix: match behavior of declare linter to checkdoc (#272) * use eask-report so eask-strict-p flag is checked * use inhibit-message to hide output from check-declare-file * set allow-error=always in declare linter * use eask--silent macro instead --- lisp/lint/declare.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/lint/declare.el b/lisp/lint/declare.el index 9809ae10..96df5f95 100644 --- a/lisp/lint/declare.el +++ b/lisp/lint/declare.el @@ -24,6 +24,11 @@ (defvar check-declare-warning-buffer) +;; +;;; Flags + +(advice-add #'eask-allow-error-p :override #'always) + ;; ;;; Core @@ -34,10 +39,10 @@ (errors)) (eask-lint-first-newline) (eask-msg "`%s` with check-declare" (ansi-green file)) - (setq errors (check-declare-file filename)) + (setq errors (eask--silent (check-declare-file filename))) (if errors (with-current-buffer check-declare-warning-buffer - (eask-msg (buffer-string))) + (eask-report (string-remove-prefix " \n" (buffer-string)))) (eask-msg "No issues found")))) (eask-start