From 73364f1a35ba05baff81d53426ae81a822785cdb Mon Sep 17 00:00:00 2001 From: ikappaki Date: Fri, 2 Jun 2023 22:28:16 +0100 Subject: [PATCH 1/2] Escape -- with double quotes (powershell compatibility) --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8dafd7a..16d07a0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -94,7 +94,7 @@ jobs: # Run `doctor' on the project itself. Git hooks are not going # to be installed in this checkout. Also, don't insist on # recent stable releases here. - ./bin/eldev -p -dtTC doctor -- -githooks -recent-stable-releases + ./bin/eldev -p -dtTC doctor "--" -githooks -recent-stable-releases env: ELDEV_LOCAL: "." From a29c590b7771839873a5f63321cf7e3ffa935cf5 Mon Sep 17 00:00:00 2001 From: ikappaki Date: Tue, 6 Jun 2023 07:14:13 +0100 Subject: [PATCH 2/2] Disable doctor eldev-file-owners test, add notes --- .github/workflows/test.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 16d07a0..e63b5c5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -94,7 +94,19 @@ jobs: # Run `doctor' on the project itself. Git hooks are not going # to be installed in this checkout. Also, don't insist on # recent stable releases here. - ./bin/eldev -p -dtTC doctor "--" -githooks -recent-stable-releases + # + # Notes + # + # 1. The `eldev-file-owners` test is disabled on MS-Windows + # because the test expects the onwer of the cache to match the + # user name, but it is instead set to the administrators group + # on the GH CI, see discussion in + # https://github.com/doublep/eldev/pull/88. + # + # 2. The `--` is escaped with `"` for cross platform + # compatibility because in PowerShell `--` is a special + # operator. + ./bin/eldev -S "(when (eq system-type 'windows-nt) (push 'eldev-file-owners eldev-doctor-disabled-tests))" -p -dtTC doctor "--" -githooks -recent-stable-releases env: ELDEV_LOCAL: "."