Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix evil-cp-up-sexp getting stuck on closing quote #111

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

bo-tato
Copy link
Contributor

@bo-tato bo-tato commented Sep 27, 2023

evil-cp-up-sexp get's stuck on closing quotes, for example in:

(message "%s" var)

with the cursor in the "%s" string, you do evil-cp-up-sexp once and it will move to the closing quote but then when you repeat evil-cp-up-sexp it will just stay stuck on the closing quote. It currently has a check if it is on a closing paren to move forward one char, I changed it so if it is on a closing paren or closing quote it will forward-char, and now it behaves as you expect. Starting with the cursor in the "%s" do evil-cp-up-sexp once and it will move to the closing quote, do evil-cp-up-sexp again and it will move to the closing paren.

@tomdl89
Copy link
Member

tomdl89 commented Sep 27, 2023

Thanks for the PR @bo-tato!

@tomdl89 tomdl89 merged commit 51b2735 into emacs-evil:master Sep 27, 2023
@bo-tato
Copy link
Contributor Author

bo-tato commented Sep 27, 2023

Thanks for adding the test! That evil-test-buffer macro that evil-cp-test-buffer makes use of is really neat, I didn't know about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants