Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org: Date movement for calendar date selection in minibuffer #835

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

julian-hoch
Copy link
Contributor

@julian-hoch julian-hoch commented Sep 28, 2024

Brief summary of what the package does

A GNU Emacs major mode for keeping notes, authoring documents, computational notebooks, literate programming, maintaining to-do lists, planning projects, and more — in a fast and effective plain text system.

Direct link to the package repository

https://orgmode.org/

Changes to existing bindings

When selecting a date in org mode (e.g. using C-c .), by default you select dates using Shift+Arrow keys.
This change will allow you to use M-hjkl/HJKL to move by day, week, month and year directly from the minibuffer.

Checklist

  • byte-compiles cleanly
  • M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • define evil-collection-org-setup with defun
  • define evil-collection-org-mode-maps with defconst
  • All functions should start with evil-collection-org-

Additional Notes

I did the rebinding with org-defkey insted of evil-collection-define-key - for some reason, the former works while the latter does not. Let me know if there is a better way.
Closes #816

@julian-hoch julian-hoch marked this pull request as ready for review September 28, 2024 10:11
@condy0919
Copy link
Collaborator

Fix the conflicts please. #837 also modified this file. Thanks.

@condy0919
Copy link
Collaborator

Use rebase instead of merge. git pull upstream master --rebase

@julian-hoch
Copy link
Contributor Author

Hmm I have never tried rebasing before, I think my attempt just now failed. I might have to start from scratch, I am not very experienced with git to be honest.

@julian-hoch
Copy link
Contributor Author

Ok I think now this worked. Is this acceptable?

@condy0919 condy0919 merged commit 01d791d into emacs-evil:master Oct 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use org calendar?
2 participants