Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign :jump to evil-{next-close,previous-open}-{brace,paren} #1844

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

leungbk
Copy link
Contributor

@leungbk leungbk commented Dec 4, 2023

This is how Vim behaves.

@leungbk
Copy link
Contributor Author

leungbk commented Dec 10, 2023

cc @tomdl89

@tomdl89 tomdl89 merged commit 7e5403c into emacs-evil:master Dec 12, 2023
4 checks passed
@tomdl89
Copy link
Member

tomdl89 commented Dec 12, 2023

Thanks for the PR @leungbk . In future, for functional changes like this, please include tests so we can catch regressions in the future. If you would like to write them retrospectively, I'll happily merge. N.b. if you do for this, make sure the jumps tested are multi-line, as I'd rather not enforce within-the-same-line jumps, as they are not usually how vim works, and maybe one day we'll switch them off, or at least allow it.

@leungbk leungbk deleted the jump-paren branch December 13, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants