-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :retab command #1846
Add :retab command #1846
Conversation
Thanks fort the PR @FrostyX . Please add some tests so a) I can easily see what your implementation does and b) to guard against regressions in the future. Cheers |
Thank you very much for the review @tomdl89, Updated, PTAL :-) |
Looks great - thanks for the tests @FrostyX ! Just need to get that |
Yeah, I am trying to figure out what is wrong. As these things usually go, the test works fine on my machine. |
FWIW, they pass on my machine too with |
OK, having looked at this, and got it passing for each, but never together, I'd be happy to remove this test. It shows a difference between |
Thank you very much for trying to debug the issue.
Do you mind if we skip the tests in the batch mode instead? I updated the PR. I think it is worth showing what the command is supposed to do, as you said in
|
See "Changing tabs" section in the Vim manual https://vimhelp.org/change.txt.html#change.txt
Yup, all good. Thanks again for the PR! |
Thank you very much. |
See "Changing tabs" section in the Vim manual
https://vimhelp.org/change.txt.html#change.txt