Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove obsoleted if/when-let and shadowed dynamic variable and fix some byte-compile warnings #4612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiennq
Copy link
Member

@kiennq kiennq commented Nov 13, 2024

This fixes:

  • obsoleted if/when-let form
  • shadowed dynamic variables in lsp-protocol (standard-output to be exact)
  • And some byte-compile warnings

There're still quite a few byte-compile warnings left, but I would like to invite anyone who has spare cycles to chimp in to fix them together

@jcs090218
Copy link
Member

Do you know why if-let and when-let is deprecated? I hope they don't since I have used those macros in many places. 😅

@kiennq
Copy link
Member Author

kiennq commented Nov 14, 2024

Do you know why if-let and when-let is deprecated? I hope they don't since I have used those macros in many places. 😅

They switched to if/when-let* form

+++
** 'if-let' and 'when-let' are now obsolete.
Use 'if-let*', 'when-let*' and 'and-let*' instead.

This effectively obsoletes the old '(if-let (SYMBOL SOMETHING) ...)'
single binding syntax, which we'd kept only for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants