Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Replace Cask with Eask #45

Merged
merged 5 commits into from
Sep 28, 2024
Merged

ci: Replace Cask with Eask #45

merged 5 commits into from
Sep 28, 2024

Conversation

jcs090218
Copy link
Contributor

Cask is deprecated, use Eask instead. 🤔

@jcs090218
Copy link
Contributor Author

You can see the test result in jcs-PR#1.

@psibi
Copy link
Member

psibi commented Sep 16, 2024

Thanks! I didn't realize that cask was deprecated. Was it announced somewhere ?

@jcs090218
Copy link
Contributor Author

They do not add new features or rarely do bug fixes. Some Emacs users declared it semi-deprecated, and I think that's true. AFAIK Cask no longer supports Windows, it’s deprecated for people who use Windows (like me). 🤔

Some people still use Cask since it will continue to support Linux (I don't know about macOS).

@psibi
Copy link
Member

psibi commented Sep 17, 2024

Thanks, got it. I don't have any objections to it, but I want to verify if I can use eask locally. The last time I checked it didn't work in NixOS.

experimental: [false]
include:
- os: ubuntu-latest
emacs-version: snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this can be removed ? It is intentional that I don't want to test on snapshot. I have seen occasional failures occurring just on snapshot which marks the entire CI as red IIRC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Removed!

# emacs-version: snapshot
# experimental: true
exclude:
- os: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed since we don't test on macos anyway ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to add the macos test in the future. But I guess we can remove it for now. :)

@jcs090218
Copy link
Contributor Author

Thanks, got it. I don't have any objections to it, but I want to verify if I can use eask locally. The last time I checked it didn't work in NixOS.

No problem! I think I accidentally removed the lock file that nixpkgs used to build the package. It should be working now; see https://search.nixos.org/packages?channel=unstable&show=eask-cli&from=0&size=50&sort=relevance&type=packages&query=eask.

@psibi psibi merged commit 3e3257e into emacs-rustic:main Sep 28, 2024
3 checks passed
@psibi
Copy link
Member

psibi commented Sep 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants