Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Replace Cask with Eask #45

Merged
merged 5 commits into from
Sep 28, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,54 @@ on:
pull_request:
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
unix-test:
test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
os:
- ubuntu-latest
# TODO: Test other OSs!
#- macos-latest
#- windows-latest
emacs-version:
- 27.2
- 28.1
- 29.3
- 28.2
- 29.4
experimental: [false]
include:
- os: ubuntu-latest
emacs-version: snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this can be removed ? It is intentional that I don't want to test on snapshot. I have seen occasional failures occurring just on snapshot which marks the entire CI as red IIRC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Removed!

experimental: true
#- os: macos-latest
# emacs-version: snapshot
# experimental: true
#- os: windows-latest
# emacs-version: snapshot
# experimental: true
exclude:
- os: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed since we don't test on macos anyway ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to add the macos test in the future. But I guess we can remove it for now. :)

emacs-version: 27.2

steps:
- uses: actions/checkout@v4

- uses: taiki-e/install-action@v2
with:
tool: just@1.16.0
- uses: purcell/setup-emacs@master

- uses: jcs090218/setup-emacs@master
with:
version: ${{ matrix.emacs-version }}

- uses: cask/setup-cask@v1
- uses: emacs-eask/setup-eask@master
with:
version: 0.9.0
version: 'snapshot'

- name: Install requirements
run: |
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
*.elc
/.cask
/.eask
/dist
/config.mk
*autoloads.el
test/test-project/target
Expand Down
13 changes: 0 additions & 13 deletions Cask

This file was deleted.

26 changes: 26 additions & 0 deletions Eask
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
(package "rustic"
"3.5"
"Rust development environment")

(package-file "rustic.el")

(files "rustic-*.el")

(source 'gnu)
(source 'melpa)

(depends-on "rust-mode" "1.0.6")
(depends-on "dash")
(depends-on "f")
(depends-on "markdown-mode")
(depends-on "s")
(depends-on "spinner")
(depends-on "xterm-color")
(depends-on "flycheck")
(depends-on "project" "0.3.0")

(development
(depends-on "ert-runner")
(depends-on "lsp-mode"))

(setq network-security-level 'low) ; see https://github.com/jcs090218/setup-emacs-windows/issues/156#issuecomment-932956432
10 changes: 5 additions & 5 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
just:
just --list --unsorted

# Install dependencies and build via cask
# Install dependencies and build via eask
build:
emacs --version
cask install
cask build
eask install-deps --dev
eask package

# Test
test:
cask emacs --batch -L . -L test -f batch-byte-compile $(cask files)
cask emacs --batch -L . -L test -l test/all-tests.el -f ert-run-tests-batch-and-exit
eask compile
eask emacs --batch -L . -L test -l test/all-tests.el -f ert-run-tests-batch-and-exit