Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to pnpm #357

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 14.x
- name: install yarn
run: npm install -g yarn
- name: install dependencies
run: yarn install
run: pnpm install
- name: lint
run: yarn lint:js
run: pnpm lint:js
- name: test
run: yarn test
run: pnpm test

try-scenarios:
name: ember-try
Expand All @@ -38,7 +36,6 @@ jobs:
matrix:
node: [ '14', '16' ]
ember-try-scenario:
- ember-lts-3.24
- ember-lts-3.28
- ember-release
- ember-beta
Expand All @@ -50,10 +47,8 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: install yarn
run: npm install -g yarn
- name: install dependencies
run: yarn install
run: pnpm install
- name: test
env:
EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }} ${{ matrix.node }}
Expand Down
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
[![Ember Observer Score](https://emberobserver.com/badges/ember-a11y-refocus.svg)](http://emberobserver.com/addons/ember-a11y-refocus)
[![Build status](https://github.com/ember-a11y/ember-a11y-refocus/actions/workflows/main.yml/badge.svg)](https://github.com/ember-a11y/ember-a11y-refocus/actions)


## What This Addon Does

This addon does three things:

1. it adds a message to the page to let the screen reader user know that the route has changed and regular page navigation can resume (it is similar to [https://github.com/ember-a11y/a11y-announcer](https://github.com/ember-a11y/a11y-announcer) but does not use `aria-live`).
2. It moves the focus to that message for the screen reader user, effectively resetting focus in Ember apps (similar to how a native web page/site works).
3. It provides a bypass mechanism so the user can skip to the page's primary content (see https://www.w3.org/TR/WCAG20-TECHS/G1.html). You can opt out of this if you want (see the `Options` section for available options).
3. It provides a bypass mechanism so the user can skip to the page's primary content (see <https://www.w3.org/TR/WCAG20-TECHS/G1.html>). You can opt out of this if you want (see the `Options` section for available options).

## Why This Addon is Needed

Expand All @@ -28,8 +28,6 @@ Async data can be loaded as it normally would be. Since this addon does not use

Since this will run before other content, focus can be programmatically moved by the developer to go somewhere else. The message should still read out, and is findable by users with screen readers.



Compatibility
------------------------------------------------------------------------------

Expand Down Expand Up @@ -74,8 +72,8 @@ export default class ApplicationController extends Controller {

The validator function:

- Receives a [Transition](https://api.emberjs.com/ember/release/classes/Transition) object containing information about the source and destination routes
- Should return `true` if refocusing should occur, otherwise `false`
* Receives a [Transition](https://api.emberjs.com/ember/release/classes/Transition) object containing information about the source and destination routes
* Should return `true` if refocusing should occur, otherwise `false`

If you wish to extend the default behavior (rather than completely replacing it), you can import the default validator like so:

Expand Down
Loading
Loading