Add support for queryParam flexibility #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
force-pushed
the
melsumner/add-qp-support
branch
from
9a071b5
to
cf07c81
Compare
MelSumner
changed the title
Add TODO comment Updated tests, worked on logic (2 failing tests at this point) Co-authored-by: Joseph D. Sumner <me@jds.dev> make the new test names more explicit set this.transition bc we can't pass an arg to a getter getting closer updated tests updated the mock in the test, tests pass add a tests link in the dummy app for easier development these comments will come out once I am confident this is correct
MelSumner
force-pushed
the
melsumner/add-qp-support
branch
from
cf07c81
to
bed977c
Compare
jgwhite
approved these changes
Jun 4, 2024
Simplify conditional logic Co-authored-by: Jamie White <jamie@jgwhite.co.uk>
josephdsumner
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR adds a conditional for
excludeAllQueryParamswhich is set tofalseby default. If set totruethen it should check for the presence of queryParams and if QPs are present, don't manage the route transition or focus.Tests passing:
