update the code based on telemetry data changes

ember-codemods · Apr 24, 2020 · 3c0e546 · 3c0e546
1 parent e052e28
commit 3c0e546
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/bin/cli.js b/bin/cli.js
@@ -7,7 +7,7 @@ const finder = require('find-package-json');
 const recast = require('ember-template-recast');
 const fs = require('fs');
 const path = require('path');
-const { appResolver, detectTypeAndName } = require('../transforms/no-implicit-this/helpers/util');
+const { appResolver, detectTypeAndName, TELEMETRY_KEY } = require('../transforms/no-implicit-this/helpers/util');
 const { gatherSingleTelemetryForUrl, getTelemetry } = require('ember-codemods-telemetry-helpers');
 const appLocation = process.argv[2];
 const args = process.argv.slice(3);
@@ -93,7 +93,13 @@ function findAppName(f) {
   debug('Gathering telemetry data from %s ...', appLocation);
 
   // This is for collecting metadata for the app just once to generate the map of lookupnames to local properties
-  await gatherSingleTelemetryForUrl(appLocation, appResolver, lookupNames, appName);
+  await gatherSingleTelemetryForUrl(
+    appLocation,
+    { telemetryKey: TELEMETRY_KEY },
+    appResolver,
+    lookupNames,
+    appName
+  );
 
   let telemetry = getTelemetry();
 

diff --git a/transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json b/transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json
@@ -1,5 +1,5 @@
 {
-  "single-telemetry": {
+  "telemetry-data": {
     "component:handlebars-with-prefix-component-properties-only": {
       "type": "Component",
       "localProperties": ["baz", "bang"],

diff --git a/transforms/no-implicit-this/helpers/plugin.js b/transforms/no-implicit-this/helpers/plugin.js
@@ -6,6 +6,7 @@ const path = require('path');
 // sorta. telemetry needs to be defined.
 // telemtry can be populated with -mock-telemetry.json
 const KNOWN_HELPERS = require('./known-helpers');
+const { TELEMETRY_KEY } = require('./util');
 
 function getTelemetryObjByName(name, telemetry) {
   let telemetryLookupName = Object.keys(telemetry).find(item => item.split(':').pop() === name);
@@ -18,7 +19,7 @@ function transform(root, options = {}) {
   let b = recast.builders;
 
   let scopedParams = [];
-  let telemetry = options.telemetry ? options.telemetry['single-telemetry'] : {};
+  let telemetry = options.telemetry ? options.telemetry[TELEMETRY_KEY] : {};
 
   let customHelpers = options.customHelpers || [];
 

diff --git a/transforms/no-implicit-this/helpers/util.js b/transforms/no-implicit-this/helpers/util.js
@@ -1,5 +1,6 @@
 const path = require('path');
 const globby = require('globby');
+const TELEMETRY_KEY = 'telemetry-data';
 
 /**
  * Generates a lookup name for a backing js class.
@@ -112,4 +113,4 @@ function appResolver(lookupNames, currAppName) {
   return mapping;
 }
 
-module.exports = { appResolver, detectTypeAndName };
+module.exports = { appResolver, detectTypeAndName, TELEMETRY_KEY };