Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Release #417

Merged
merged 1 commit into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .release-plan.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"solution": {
"ember-no-implicit-this-codemod": {
"impact": "major",
"oldVersion": "2.1.0",
"newVersion": "3.0.0",
"constraints": [
{
"impact": "major",
"reason": "Appears in changelog section :boom: Breaking Change"
},
{
"impact": "minor",
"reason": "Appears in changelog section :rocket: Enhancement"
},
{
"impact": "patch",
"reason": "Appears in changelog section :house: Internal"
}
],
"pkgJSONPath": "./package.json"
}
},
"description": "## Release (2024-01-19)\n\nember-no-implicit-this-codemod 3.0.0 (major)\n\n#### :boom: Breaking Change\n* `ember-no-implicit-this-codemod`\n * [#405](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/405) drop support for Node < 16 ([@mansona](https://github.com/mansona))\n\n#### :rocket: Enhancement\n* `ember-no-implicit-this-codemod`\n * [#400](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/400) Update ember-codemods-telemetry-helpers for Mac M support ([@Mikek2252](https://github.com/Mikek2252))\n\n#### :house: Internal\n* `ember-no-implicit-this-codemod`\n * [#418](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/418) Typescript ([@mansona](https://github.com/mansona))\n * [#416](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/416) setup release-plan ([@mansona](https://github.com/mansona))\n * [#401](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/401) swap to pnpm ([@mansona](https://github.com/mansona))\n * [#409](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/409) add grouping to dependabot config ([@mansona](https://github.com/mansona))\n\n#### Committers: 2\n- Chris Manson ([@mansona](https://github.com/mansona))\n- Michael Kerr ([@Mikek2252](https://github.com/Mikek2252))\n"
}
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,26 @@
# Changelog
## Release (2024-01-19)

ember-no-implicit-this-codemod 3.0.0 (major)

#### :boom: Breaking Change
* `ember-no-implicit-this-codemod`
* [#405](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/405) drop support for Node < 16 ([@mansona](https://github.com/mansona))

#### :rocket: Enhancement
* `ember-no-implicit-this-codemod`
* [#400](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/400) Update ember-codemods-telemetry-helpers for Mac M support ([@Mikek2252](https://github.com/Mikek2252))

#### :house: Internal
* `ember-no-implicit-this-codemod`
* [#418](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/418) Typescript ([@mansona](https://github.com/mansona))
* [#416](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/416) setup release-plan ([@mansona](https://github.com/mansona))
* [#401](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/401) swap to pnpm ([@mansona](https://github.com/mansona))
* [#409](https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/409) add grouping to dependabot config ([@mansona](https://github.com/mansona))

#### Committers: 2
- Chris Manson ([@mansona](https://github.com/mansona))
- Michael Kerr ([@Mikek2252](https://github.com/Mikek2252))

## v2.1.0 (2022-01-11)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-no-implicit-this-codemod",
"version": "2.1.0",
"version": "3.0.0",
"description": "Codemods for transforming variable usage to be prefixed with `this`, when appropriate",
"keywords": [
"codemod-cli"
Expand Down
109 changes: 109 additions & 0 deletions transforms/no-implicit-this/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ ember-no-implicit-this-codemod no-implicit-this path/of/files/ or/some**/*glob.j
* [handlebars-with-wall-street-syntax](#handlebars-with-wall-street-syntax)
* [handlebars-without-params](#handlebars-without-params)
* [has-block](#has-block)
* [paths](#paths)
* [tagged-templates-js](#tagged-templates-js)
* [tagged-templates-ts](#tagged-templates-ts)
* [void-elements](#void-elements)
<!--FIXTURES_TOC_END-->

Expand Down Expand Up @@ -424,6 +427,112 @@ ember-no-implicit-this-codemod no-implicit-this path/of/files/ or/some**/*glob.j
{{if (has-block-params "main") "block"}}
{{#if (has-block-params "main")}}block{{/if}}

```
---
<a id="paths">**paths**</a>

**Input** (<small>[paths.input.hbs](transforms/no-implicit-this/__testfixtures__/paths.input.hbs)</small>):
```hbs
{{foo-bar-baz}}
{{baz}}

```

**Output** (<small>[paths.output.hbs](transforms/no-implicit-this/__testfixtures__/paths.output.hbs)</small>):
```hbs
{{foo-bar-baz}}
{{this.baz}}

```
---
<a id="tagged-templates-js">**tagged-templates-js**</a>

**Input** (<small>[tagged-templates-js.input.js](transforms/no-implicit-this/__testfixtures__/tagged-templates-js.input.js)</small>):
```js
import { hbs as echHBS } from 'ember-cli-htmlbars';
import hipHBS from 'htmlbars-inline-precompile';
import echipHBS from 'ember-cli-htmlbars-inline-precompile';
import { hbs } from 'unknown-tag-source';

echHBS`
Hello,
{{target}}!
\n
`;

hipHBS`Hello, {{target}}!`;

echipHBS`Hello, {{target}}!`;

hbs`Hello, {{target}}!`;

```

**Output** (<small>[tagged-templates-js.output.js](transforms/no-implicit-this/__testfixtures__/tagged-templates-js.output.js)</small>):
```js
import { hbs as echHBS } from 'ember-cli-htmlbars';
import hipHBS from 'htmlbars-inline-precompile';
import echipHBS from 'ember-cli-htmlbars-inline-precompile';
import { hbs } from 'unknown-tag-source';

echHBS`
Hello,
{{this.target}}!
\n
`;

hipHBS`Hello, {{this.target}}!`;

echipHBS`Hello, {{this.target}}!`;

hbs`Hello, {{target}}!`;

```
---
<a id="tagged-templates-ts">**tagged-templates-ts**</a>

**Input** (<small>[tagged-templates-ts.input.ts](transforms/no-implicit-this/__testfixtures__/tagged-templates-ts.input.ts)</small>):
```ts
import { hbs as echHBS } from 'ember-cli-htmlbars';
import hipHBS from 'htmlbars-inline-precompile';
import echipHBS from 'ember-cli-htmlbars-inline-precompile';

declare const hbs: unknown;

echHBS`
Hello,
{{target}}!
\n
`;

hipHBS`Hello, {{target}}!`;

echipHBS`Hello, {{target}}!`;

hbs`Hello, {{target}}!`;

```

**Output** (<small>[tagged-templates-ts.output.ts](transforms/no-implicit-this/__testfixtures__/tagged-templates-ts.output.ts)</small>):
```ts
import { hbs as echHBS } from 'ember-cli-htmlbars';
import hipHBS from 'htmlbars-inline-precompile';
import echipHBS from 'ember-cli-htmlbars-inline-precompile';

declare const hbs: unknown;

echHBS`
Hello,
{{this.target}}!
\n
`;

hipHBS`Hello, {{this.target}}!`;

echipHBS`Hello, {{this.target}}!`;

hbs`Hello, {{target}}!`;

```
---
<a id="void-elements">**void-elements**</a>
Expand Down