Merge pull request #1766 from embrace-io/fix-null-sid

Prevent null session ID crashing ndk processing
embrace-io · Dec 19, 2024 · ba6f189 · ba6f189
2 parents aefef3f + 26832fa
commit ba6f189
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/...main/kotlin/io/embrace/android/embracesdk/internal/ndk/NativeCrashHandlerInstallerImpl.kt b/...main/kotlin/io/embrace/android/embracesdk/internal/ndk/NativeCrashHandlerInstallerImpl.kt
@@ -43,21 +43,23 @@ class NativeCrashHandlerInstallerImpl(
     private fun startNativeCrashMonitoring() {
         try {
             if (sharedObjectLoader.loadEmbraceNative()) {
-                delegate.onSessionChange(sessionIdTracker.getActiveSessionId(), createNativeReportPath())
+                delegate.onSessionChange(sanitizeSessionId(sessionIdTracker.getActiveSessionId()), createNativeReportPath())
                 mainThreadHandler.postAtFrontOfQueue { installSignals() }
                 mainThreadHandler.postDelayed(
                     Runnable(::checkSignalHandlersOverwritten),
                     HANDLER_CHECK_DELAY_MS
                 )
                 sessionIdTracker.addListener { sessionId ->
-                    delegate.onSessionChange(sessionId, createNativeReportPath())
+                    delegate.onSessionChange(sanitizeSessionId(sessionId), createNativeReportPath())
                 }
             }
         } catch (ex: Exception) {
             logger.trackInternalError(InternalErrorType.NATIVE_HANDLER_INSTALL_FAIL, ex)
         }
     }
 
+    private fun sanitizeSessionId(sid: String?) = sid ?: "null"
+
     private fun checkSignalHandlersOverwritten() {
         if (configService.autoDataCaptureBehavior.is3rdPartySigHandlerDetectionEnabled()) {
             val culprit = delegate.checkForOverwrittenHandlers()
@@ -100,7 +102,7 @@ class NativeCrashHandlerInstallerImpl(
     private fun createNativeReportPath(): String {
         val metadata = StoredTelemetryMetadata(
             timestamp = clock.now(),
-            uuid = sessionIdTracker.getActiveSessionId() ?: "null",
+            uuid = sanitizeSessionId(sessionIdTracker.getActiveSessionId()),
             processId = processIdProvider(),
             envelopeType = SupportedEnvelopeType.CRASH,
             payloadType = PayloadType.NATIVE_CRASH,

diff --git a/...ndroid-core/src/main/kotlin/io/embrace/android/embracesdk/internal/ndk/jni/JniDelegate.kt b/...ndroid-core/src/main/kotlin/io/embrace/android/embracesdk/internal/ndk/jni/JniDelegate.kt
@@ -10,7 +10,7 @@ interface JniDelegate {
         devLogging: Boolean,
     )
     fun updateMetaData(metadata: String?)
-    fun onSessionChange(sessionId: String?, reportPath: String)
+    fun onSessionChange(sessionId: String, reportPath: String)
     fun updateAppState(appState: String?)
     fun getCrashReport(path: String): String?
     fun checkForOverwrittenHandlers(): String?

diff --git a/...id-core/src/main/kotlin/io/embrace/android/embracesdk/internal/ndk/jni/JniDelegateImpl.kt b/...id-core/src/main/kotlin/io/embrace/android/embracesdk/internal/ndk/jni/JniDelegateImpl.kt
@@ -11,7 +11,7 @@ class JniDelegateImpl : JniDelegate {
     )
 
     external override fun updateMetaData(metadata: String?)
-    external override fun onSessionChange(sessionId: String?, reportPath: String)
+    external override fun onSessionChange(sessionId: String, reportPath: String)
     external override fun updateAppState(appState: String?)
     external override fun getCrashReport(path: String): String?
     external override fun checkForOverwrittenHandlers(): String?

diff --git a/embrace-test-fakes/src/main/kotlin/io/embrace/android/embracesdk/fakes/FakeJniDelegate.kt b/embrace-test-fakes/src/main/kotlin/io/embrace/android/embracesdk/fakes/FakeJniDelegate.kt
@@ -25,7 +25,7 @@ class FakeJniDelegate : JniDelegate {
         // do nothing
     }
 
-    override fun onSessionChange(sessionId: String?, reportPath: String) {
+    override fun onSessionChange(sessionId: String, reportPath: String) {
         this.reportPath = reportPath
     }