Add session properties to native crashes from the associated session

[bidetofevil]

Goal

Use appState and session properties from associated session when sending native crashes. Prior to this, metadata from the current session was being used erroneously. Now, we will grab this from the session that is associated with the crash that will be resurrected.

In a later PR, the code will be modified to take from the cached payload envelope if a session doesn't exist.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[bidetofevil]

• Add session properties to native crashes from the associated session #1744 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 88.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (f3c3d7f) to head (8f57ff9).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...nal/resurrection/PayloadResurrectionServiceImpl.kt	90.19%	1 Missing and 4 partials ⚠️
...android/embracesdk/internal/payload/EnvelopeExt.kt	0.00%	0 Missing and 1 partial ⚠️
...oid/embracesdk/internal/spans/EmbraceExtensions.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   85.31%   85.28%   -0.04%     
==========================================
  Files         464      464              
  Lines       10775    10793      +18     
  Branches     1591     1596       +5     
==========================================
+ Hits         9193     9205      +12     
- Misses        870      871       +1     
- Partials      712      717       +5     

Files with missing lines	Coverage Δ
...acesdk/internal/arch/schema/EmbraceAttributeExt.kt	100.00% <100.00%> (ø)
...esdk/internal/injection/NativeFeatureModuleImpl.kt	100.00% <ø> (ø)
...bracesdk/internal/ndk/NativeCrashDataSourceImpl.kt	98.00% <100.00%> (+0.08%)	⬆️
...android/embracesdk/internal/payload/EnvelopeExt.kt	25.00% <0.00%> (-8.34%)	⬇️
...oid/embracesdk/internal/spans/EmbraceExtensions.kt	75.75% <0.00%> (-2.37%)	⬇️
...nal/resurrection/PayloadResurrectionServiceImpl.kt	85.05% <90.19%> (-2.62%)	⬇️

[fractalwrench]

LGTM

[fractalwrench]

I didn't see anywhere this function was used in review & am not sure of its purpose. It seems like either the name or functionality is wrong as the session properties don't live exclusively on a span's attributes?

[bidetofevil]

I think you might've been looking at an older version? I added usage after the first commit - in line 75 of PayloadResurrectionServiceImpl.kt

[fractalwrench]

This can be deleted

[bidetofevil]

Did so in an subsequent commit

[fractalwrench]

This function is fairly long with lots of indentation & that makes it hard to read IMO. I'd suggest breaking it into 2-3 smaller functions

[bidetofevil]

Sure. Good call.

[bidetofevil]

Merge activity

• Dec 9, 2:40 PM EST: A user merged this pull request with Graphite.